Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hardtime-nvim): call enable() explicitly, remove redundant keys #589

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix(hardtime-nvim): call enable() explicitly, remove redundant keys #589

merged 2 commits into from
Oct 5, 2023

Conversation

slowsage
Copy link
Contributor

📑 Description

hardtime hooks to BufEnter to defer enabling when setup is called with the plugin enabled. On occasion, User AstroFile gets called after BufEnter.

This makes the plugin wait for a BufEnter that never happens. This PR calls enable() and setup() explicitly with the opts.

ℹ Additional Information

This PR also removes redundant keys that are present in the plugin already.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited by Uzaaft
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@slowsage
Copy link
Contributor Author

slowsage commented Sep 27, 2023 •
edited by Uzaaft
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

* If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. `feat(utility): added noice.nvim plugin`

* If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. `fix(noice-nvim): fix LSP handler error`

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Note on the last checkbox. I reused opts (after removing redundant keys) but I have to call config to call setup. I left the opts variable as is as opposed to making opts a function since we need an opts variable anyway for the remaining options.

@Uzaaft
Copy link
Member

Uzaaft commented Oct 5, 2023

Sorry for the delay, I’ll be merging this within the next 12h.

@Uzaaft Uzaaft merged commit d79add3 into AstroNvim:main Oct 5, 2023
@astronvimbot astronvimbot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzaaft Uzaaft Uzaaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowsage @Uzaaft